Internal refactoring to avoid unneeded netlink parsing #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amorenoz please review |
amorenoz
reviewed
Sep 18, 2023
amorenoz
reviewed
Sep 18, 2023
lmilleri
force-pushed
the
vdpa-device-by-pci
branch
from
1a135be
to
830f29d
Compare
amorenoz
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Regarding your commit msg, your signing with:
Signed-off-by: Leonardo Milleri <[email protected]>
Is that intentional? Maybe you want to configure the email in your local repo.
lmilleri
force-pushed
the
vdpa-device-by-pci
branch
2 times, most recently
from
0356b87
to
f66bb12
Compare
lmilleri
changed the title
amorenoz
reviewed
Sep 25, 2023
|
Also, the commit title is a bit misleading as there is no public function change in this PR any more. |
lmilleri
force-pushed
the
vdpa-device-by-pci
branch
from
f66bb12
to
c692869
Compare
lmilleri
changed the title
lmilleri
force-pushed
the
vdpa-device-by-pci
branch
from
c692869
to
f04f891
Compare
amorenoz
reviewed
Sep 25, 2023
lmilleri
force-pushed
the
vdpa-device-by-pci
branch
from
f04f891
to
b5efc6a
Compare
The parsing of some netlink structures is performed only for those vdpa objects that need to be returned to the user. Signed-off-by: Leonardo Milleri <[email protected]>
lmilleri
force-pushed
the
vdpa-device-by-pci
branch
from
b5efc6a
to
3335d73
Compare
amorenoz
approved these changes
Sep 26, 2023
|
Thanks @lmilleri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal refactoring to avoid unneeded netlink parsing
The parsing of some netlink structures is performed only for those vdpa objects
that need to be returned to the user.