Set kernel arg PCI realloc on "cannot allocate memory" on VF creation

When creating VFs via sysfs sriov_numvfs, there is a chance of getting the error "cannot allocate memory". This could occur when the BIOS is not providing enough MMIO space for VFs. A solution is to reallocate the MMIO space via "pci=realloc". Signed-off-by: William Zhao <[email protected]>
k8snetworkplumbingwg · Sep 22, 2023 · 5fda561 · 5fda561
1 parent 6136cbf
commit 5fda561
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/plugins/generic/generic_plugin.go b/pkg/plugins/generic/generic_plugin.go
@@ -2,6 +2,7 @@ package generic
 
 import (
 	"bytes"
+	"errors"
 	"os/exec"
 	"reflect"
 	"strconv"
@@ -172,6 +173,10 @@ func (p *GenericPlugin) Apply() error {
 	}
 
 	if err := utils.SyncNodeState(p.DesireState, pfsToSkip); err != nil {
+		// Catch the "cannot allocate memory" error and try to use PCI realloc
+		if errors.Is(err, syscall.ENOMEM) {
+			p.addToDesiredKernelArgs(utils.KernelArgPciRealloc)
+		}
 		return err
 	}
 	p.LastState = &sriovnetworkv1.SriovNetworkNodeState{}

diff --git a/pkg/utils/utils.go b/pkg/utils/utils.go
@@ -42,6 +42,7 @@ const (
 	DeviceBF2             = "a2d6"
 	DeviceBF3             = "a2dc"
 
+	KernelArgPciRealloc = "pci=realloc"
 	KernelArgIntelIommu = "intel_iommu=on"
 	KernelArgIommuPt    = "iommu=pt"
 )