Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor network controller namespace handlers #513

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Refactor network controller namespace handlers #513

merged 1 commit into from
Oct 16, 2023

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Sep 28, 2023

Move namespace handlers to its own named function in SriovNetworkReconciler and SriovIBNetworkReconciler. These changes aim to reduce complexity and increase readability.

cc @bn222

@zeeke
Refactor network controller namespace handlers
6f63125 
Move namespace handlers to its own named function in
`SriovNetworkReconciler` and `SriovIBNetworkReconciler`.
These changes aim to reduce complexity and increase readability.

Signed-off-by: Andrea Panattoni <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke zeeke mentioned this pull request Sep 28, 2023
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6335965039

  • 28 of 34 (82.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 25.812%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovibnetwork_controller.go 14 17 82.35%
controllers/sriovnetwork_controller.go 14 17 82.35%
Totals Coverage Status
Change from base Build 6335355154: 0.1%
Covered Lines: 2170
Relevant Lines: 8407
💛 - Coveralls

@bn222
Copy link
Collaborator

bn222 commented Sep 28, 2023

LGTM

@wizhaoredhat
Copy link
Contributor

lgtm

SchSeba
SchSeba approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

adrianchiris
adrianchiris approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
Copy link
Collaborator

not sure ocp failure is related to this PR. i see no logs.

re-triggered the job. @zeeke feel free to self merge this one if you see failure is non related to this PR

@zeeke
Copy link
Member Author

zeeke commented Oct 16, 2023

All checks are green now. We probably hit a CI flake. Merging

@zeeke zeeke merged commit d5499fd into k8snetworkplumbingwg:master Oct 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zeeke @coveralls @bn222 @wizhaoredhat @adrianchiris @SchSeba