Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set mellanox ib vf state to Follow #496

Closed

Conversation

wangyd1988
Copy link

According to the mellanox 'https://enterprise-support.nvidia.com/s/article/howto-configure-sr-iov-for-connect-ib-connectx-4-with-kvm--infiniband-x' documentation, we must set the mellanox ib vf state to Follow when using the mellanox ib network card

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@wangyd1988
Copy link
Author

/test-all

@SchSeba
Copy link
Collaborator

SchSeba commented Sep 4, 2023

Hi @wangyd1988

should this change be part of the https://github.com/k8snetworkplumbingwg/ib-sriov-cni instead of the operator?

@adrianchiris
Copy link
Collaborator

adrianchiris commented Sep 4, 2023

@wangyd1988 are you running VM with an IB Sriov VF ?

this probably needs to be part of ib-sriov-cni as @SchSeba pointed out.

@wangyd1988
Copy link
Author

Hi @wangyd1988

should this change be part of the https://github.com/k8snetworkplumbingwg/ib-sriov-cni instead of the operator?

I think it's part of the operator, because pf also needs to configure state, and it's part of the vm configuration

@wangyd1988
Copy link
Author

Hi @wangyd1988
should this change be part of the https://github.com/k8snetworkplumbingwg/ib-sriov-cni instead of the operator?

I think it's part of the operator, because pf also needs to configure state, and it's part of the vm configuration

yes,

@wangyd1988 are you running VM with an IB Sriov VF ?

this probably needs to be part of ib-sriov-cni as @SchSeba pointed out.

Yes, I ran it in a vm

@adrianchiris
Copy link
Collaborator

adrianchiris commented Sep 5, 2023

@wangyd1988 can you explain your use-case and what exactly is not working ?

if you use ib-sriov-cni you can set the link_state configuration in the network definition.
if you set it to auto it will have the same effect. (it also relies on upstream APIs and not driver specific)

@adrianchiris
Copy link
Collaborator

@wangyd1988 please see the alternatives above, the recommended way is to use ib-sriov-cni to set the link state.
which utilizes non driver-specific APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants