improve github actions #515

SchSeba · 2023-10-02T08:40:22Z

add cancel on progress and also run the virtual cluster tests only if all the light lanes like build and unit tests pass to save resources

github-actions · 2023-10-02T08:40:34Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

bn222 · 2023-10-02T08:46:39Z

Can you change the commit message to:

Speed up GitHub action runs and save resources

- Require short running actions (golangci, test, build) before starting slower virtual-k8s-cluster and only run virtual-ocp when virtual-k8s-cluster succeed
- Allow cancellation

These two changes together reduce the amount of resources used

github-actions · 2023-10-02T09:21:14Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-02T09:22:24Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

bn222 · 2023-10-02T09:39:09Z

LGTM

SchSeba · 2023-10-02T09:39:45Z

/hold
this doesn't run the virtual cluster now ;(

github-actions · 2023-10-02T09:46:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2023-10-02T09:53:55Z

Pull Request Test Coverage Report for Build 6422033325

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 25.082%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovnetwork_controller.go	2	73.64%

Totals
Change from base Build 6418477426:	0.03%
Covered Lines:	2226
Relevant Lines:	8875

💛 - Coveralls

github-actions · 2023-10-02T10:01:42Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-02T10:02:47Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2023-10-02T10:04:09Z

I moved the virtual cluster to the same file as the build and unit test so we can have a dependency.
I also changed the name from Go to Test SR-IOV Operator to better represent the flow

SchSeba · 2023-10-02T10:04:21Z

/hold cancel

github-actions · 2023-10-02T10:06:06Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-02T11:34:55Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-02T11:45:44Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-02T13:20:40Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

- Require short running actions (golangci, test, build) before starting slower virtual-k8s-cluster and only run virtual-ocp when virtual-k8s-cluster succeed - Allow cancellation These two changes together reduce the amount of resources used Signed-off-by: Sebastian Sch <[email protected]>

github-actions · 2023-10-02T15:21:30Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-02T15:45:37Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

LGTM

adrianchiris · 2023-10-03T13:32:38Z

hack/run-e2e-conformance-virtual-cluster.sh

@@ -130,18 +130,67 @@ kcli ssh $cluster_name-ctlplane-0 << EOF
 sudo su
 echo '$insecure_registry' > /etc/containers/registries.conf.d/003-internal.conf
 systemctl restart crio
+
+echo '[connection]


nit: define function and call it for each node ?

github-actions · 2023-10-05T15:45:52Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-05T16:18:51Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-05T16:24:17Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-05T16:50:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

disable dhcp on vfs for vanilly k8s CI. if we don't disable it the device plugin will not use this devices Signed-off-by: Sebastian Sch <[email protected]>

github-actions · 2023-10-05T16:51:25Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba force-pushed the update_github_actions branch from 7bee133 to 1a9b709 Compare October 2, 2023 09:21

SchSeba force-pushed the update_github_actions branch from 1a9b709 to 1f5dfaa Compare October 2, 2023 09:22

github-actions bot added the hold label Oct 2, 2023

SchSeba force-pushed the update_github_actions branch from 1f5dfaa to 3576111 Compare October 2, 2023 09:45

SchSeba force-pushed the update_github_actions branch from 3576111 to 21cd829 Compare October 2, 2023 10:01

SchSeba force-pushed the update_github_actions branch from 21cd829 to 52e81c0 Compare October 2, 2023 10:02

github-actions bot removed the hold label Oct 2, 2023

SchSeba force-pushed the update_github_actions branch from 52e81c0 to c89dfc1 Compare October 2, 2023 10:05

SchSeba force-pushed the update_github_actions branch from c89dfc1 to c45cf80 Compare October 2, 2023 11:34

SchSeba force-pushed the update_github_actions branch from c45cf80 to c5770d0 Compare October 2, 2023 11:45

SchSeba force-pushed the update_github_actions branch from fcc9137 to f2489bb Compare October 2, 2023 15:21

SchSeba force-pushed the update_github_actions branch from f2489bb to 8bf9d47 Compare October 2, 2023 15:45

zeeke approved these changes Oct 3, 2023

View reviewed changes

adrianchiris reviewed Oct 3, 2023

View reviewed changes

e0ne approved these changes Oct 5, 2023

View reviewed changes

SchSeba force-pushed the update_github_actions branch from 8bf9d47 to 3cc8117 Compare October 5, 2023 15:45

SchSeba force-pushed the update_github_actions branch from 3cc8117 to cd17b4a Compare October 5, 2023 16:18

SchSeba force-pushed the update_github_actions branch from cd17b4a to 3996f73 Compare October 5, 2023 16:24

SchSeba force-pushed the update_github_actions branch from 3996f73 to d54293f Compare October 5, 2023 16:50

add networkManager to disable dhcp on vfs

41774fb

disable dhcp on vfs for vanilly k8s CI. if we don't disable it the device plugin will not use this devices Signed-off-by: Sebastian Sch <[email protected]>

SchSeba force-pushed the update_github_actions branch from d54293f to 41774fb Compare October 5, 2023 16:51

zeeke merged commit 44afc00 into k8snetworkplumbingwg:master Oct 9, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve github actions #515

improve github actions #515

SchSeba commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

bn222 commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

bn222 commented Oct 2, 2023

SchSeba commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

coveralls commented Oct 2, 2023 •

edited

Loading

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

SchSeba commented Oct 2, 2023

SchSeba commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

zeeke left a comment

adrianchiris Oct 3, 2023

SchSeba Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

improve github actions #515

improve github actions #515

Conversation

SchSeba commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

bn222 commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

bn222 commented Oct 2, 2023

SchSeba commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

coveralls commented Oct 2, 2023 • edited Loading

Pull Request Test Coverage Report for Build 6422033325

💛 - Coveralls

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

SchSeba commented Oct 2, 2023

SchSeba commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

github-actions bot commented Oct 2, 2023

zeeke left a comment

Choose a reason for hiding this comment

adrianchiris Oct 3, 2023

Choose a reason for hiding this comment

SchSeba Oct 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

coveralls commented Oct 2, 2023 •

edited

Loading