Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using iface.Name from spec during configuration. #807

Conversation

ykulazhenkov
Copy link
Collaborator

This ensures proper handling when the interface name changed for some reason.

Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11937142059

Details

  • 20 of 23 (86.96%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 46.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/internal/sriov/sriov.go 20 23 86.96%
Files with Coverage Reduction New Missed Lines %
controllers/helper.go 1 69.6%
controllers/generic_network_controller.go 5 74.38%
Totals Coverage Status
Change from base Build 11931554664: -0.04%
Covered Lines: 7099
Relevant Lines: 15109

💛 - Coveralls

@ykulazhenkov ykulazhenkov force-pushed the pr-fix-iface-name-usage branch 2 times, most recently from cda5cfb to 4930922 Compare November 20, 2024 13:35
@ykulazhenkov ykulazhenkov marked this pull request as ready for review November 20, 2024 15:50
@ykulazhenkov ykulazhenkov changed the title WIP: Avoid using iface.Name from spec during configuration. Avoid using iface.Name from spec during configuration. Nov 20, 2024
This ensures proper handling when the interface name changed for some reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants