Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deprecated warnings to admission.Warnings in webhook #532

Closed
burmanm opened this issue Jun 9, 2023 · 1 comment · Fixed by #619
Closed

Move deprecated warnings to admission.Warnings in webhook #532

burmanm opened this issue Jun 9, 2023 · 1 comment · Fixed by #619
Assignees
@burmanm
Labels
done Issues in the state 'done' enhancement New feature or request refactoring

Comments

@burmanm
Copy link
Contributor

burmanm commented Jun 9, 2023

What is missing?

controller-runtime 0.15.0 introduces the ability to create webhook warnings. We should move all our deprecated check to warnings. Instead of moving Create to failure (Update still allows deprecated methods).

Why is this needed?

Better response to user inputs.
@burmanm burmanm added the enhancement New feature or request label Jun 9, 2023
@adejanovski adejanovski added the product-backlog Issues in the state 'product-backlog' label Jun 19, 2023
@adejanovski adejanovski added in-progress Issues in the state 'in-progress' and removed product-backlog Issues in the state 'product-backlog' labels Feb 27, 2024
@burmanm burmanm self-assigned this Feb 27, 2024
@burmanm
Copy link
Contributor Author

burmanm commented Feb 27, 2024

Depends on #618

@burmanm burmanm mentioned this issue Feb 27, 2024
Merged
5 tasks
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' review Issues in the state 'review' and removed in-progress Issues in the state 'in-progress' ready-for-review Issues in the state 'ready-for-review' labels Feb 27, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burmanm burmanm

Labels
done Issues in the state 'done' enhancement New feature or request refactoring
Projects
No open projects
K8ssandra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependencies, warnings webhook burmanm/cass-operator
2 participants
@burmanm @adejanovski