Adding debug target on Makefile, fixing leaderElection and imageConfi… #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, slipped a bit under my radar. The debug targets in Makefile are alright, but the config changes are not. The /configs is the intended default location and we want to keep leaderElection enabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gFile reference
What this PR does:
This PR adds the
make debugdirective, which allows developers to attach the debugger to delve locally in port 2345.It also fixes the config files for the manager and container images, to correctly load the default operator config, and allow for properly downloading the cassandra container images.
Which issue(s) this PR fixes:
Fixes #610
Checklist