TLS should be supported as scheme, like SSL

[dpwspoon]

The gateway-config can currently have ssl addresses, it should really be tls, but for backwards compatibility we should support both.

[sbadugu]

@irina-mitrea-luxoft (CC @DoruM):
Sorry, there was a miscommunication between me and David. Apparently, this has already been implemented, so please don't work on this.

[dpwspoon]

@justinma246 what is the update on this. I believe you have already started an implementation of allowing TLS in the config but then just translating it internally to ssl.

@DoruM perhaps you could review Justin's changes once he has a PR

[justinma246]

@dpwspoon
I believe I have finished the implementation (worked with all manual tests for gateway-config), but have not finished the unit tests

[justinma246]

The PR is here: #653

[dpwspoon]

This looks good to me, but I assume there needs to be a enterprise.gateway Pull request

[justinma246]

@dpwspoon I added the enterprise.gateway PR

[sbadugu]

This is not completed, yet. In a meeting with @robinzimmermann and @jitsni , the decision was made that we will not advertise or document this feature until we have figured out a way to implement it properly.

Right now, the implementation is half baked where the scheme socks+tls is internally replaced by socks+ssl and the logs will also show socks+ssl. From a customer point of view, it looks bad when they use socks+tls but the logs indicate socks+ssl, so the work done for this feature will stay in the product but we will not release note it until we fix the issue completely.