Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Introduce the Team CRD and depricate Kabanero CRD #704

Open
kaczyns opened this issue May 11, 2020 · 0 comments
Open

Introduce the Team CRD and depricate Kabanero CRD #704

kaczyns opened this issue May 11, 2020 · 0 comments

Comments

@kaczyns
Copy link
Member

kaczyns commented May 11, 2020

The Team CRD effectively replaces the Kabanero CRD, although their structure will be nearly identical and for the time being the kabanero controller can and should watch and act on either/or. It may be necessary to use an intermediate representation of the CRD and then convert back to the proper type later. I am thinking that the CRD should be versioned v1alpha2 but I am open to other suggestions.

The Team CRD should not allow the admission controller webhook to be specified (the Kabanero CRD has this information in it but it should be ignored by the controller, since the Config controller now handles this).

The Team CRD should have a new spec attribute repositoryType which can be set to one of appsody or odo. The Kabanero CRD should implicitly be type appsody. The kabanero/team controller should only allow the given repository type to be read. This means for odo presently the controller can't do anything with it. That will change shortly.

The admission controller webhook will need new endpoints to act on the Team CRD. These should be nearly identical to Kabanero v1alpha2.

After this change is merged, an issue should be opened against CLI Service and landing page, for them to be able to process the new Team CR instances.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant