Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify me when nixpkgs merged several commits in several branches #846

Closed
kachick opened this issue Oct 16, 2024 · 21 comments · Fixed by #903
Closed

Notify me when nixpkgs merged several commits in several branches #846

kachick opened this issue Oct 16, 2024 · 21 comments · Fixed by #903
Labels
enhancement New feature or request

Comments

@kachick
Copy link
Owner

kachick commented Oct 16, 2024 •
edited
Loading

Why

Note

In local, we can do

> git branch upstream/nixos-24.05 --contains ad770642546822d5146f23f739c4bd57d850f13e

https://stackoverflow.com/questions/43535132/given-a-commit-id-how-to-determine-if-current-branch-contains-the-commit

However it is annoy to keep running in bg
@kachick kachick added the enhancement New feature or request label Oct 16, 2024
@kachick kachick changed the title Add notifications when nixpkgs merged several commits in several branches Notify me when nixpkgs merged several commits in several branches Oct 16, 2024
@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024

https://ohbarye.hatenablog.jp/entry/2016/07/20/003903 👀

@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024

https://swet.dena.com/entry/2020/12/10/100000

@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024 •
edited
Loading

2m4s

🎯 /tmp/tmp.Zl7lNTtKDk zsh
> time git clone [email protected]:NixOS/nixpkgs.git --branch nixos-unstable --single-branch --shallow-since='2024/05/01'
Cloning into 'nixpkgs'...
remote: Enumerating objects: 834125, done.
remote: Counting objects: 100% (834125/834125), done.
remote: Compressing objects: 100% (305303/305303), done.
remote: Total 834125 (delta 410862), reused 810040 (delta 392003), pack-reused 0 (from 0)
Receiving objects: 100% (834125/834125), 523.41 MiB | 12.30 MiB/s, done.
Resolving deltas: 100% (410862/410862), done.
Checking connectivity: 834124, done.
Updating files: 100% (43911/43911), done.
git clone [email protected]:NixOS/nixpkgs.git --branch nixos-unstable    82.10s user 21.91s system 83% cpu 2:04.76 total

47s

> time git clone [email protected]:NixOS/nixpkgs.git --branch nixos-unstable --single-branch --shallow-since='2024/10/01'
Cloning into 'nixpkgs'...
remote: Enumerating objects: 260035, done.
remote: Counting objects: 100% (260035/260035), done.
remote: Compressing objects: 100% (138940/138940), done.
remote: Total 260035 (delta 62210), reused 242708 (delta 49218), pack-reused 0 (from 0)
Receiving objects: 100% (260035/260035), 170.13 MiB | 11.05 MiB/s, done.
Resolving deltas: 100% (62210/62210), done.
Checking connectivity: 260035, done.
Updating files: 100% (43911/43911), done.
git clone [email protected]:NixOS/nixpkgs.git --branch nixos-unstable    14.78s user 15.52s system 64% cpu 47.343 total

@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024

https://swet.dena.com/entry/2021/07/12/120000

@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024

https://docs.github.com/ja/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request

merge_commit_sha

@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024

https://zenn.dev/kaakaa/articles/git-fetch-specific-commit-depth-1

@kachick
Copy link
Owner Author

kachick commented Oct 31, 2024 

> git log --date=iso-strict --format='%cd' 4d5acfd5f8f9c800ac57d003d7038f607544ef48.. -1
2024-10-31T21:43:14+09:00

This was referenced Oct 31, 2024
Open
Closed
Merged
@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024

https://stackoverflow.com/questions/2706797/finding-what-branch-a-git-commit-came-from

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024 •
edited
Loading

2m15s

git clone --branch nixos-unstable --single-branch --no-checkout --shallow-since=2024-01-01 https://github.com/NixOS/nixpkgs.git nixpkgs

git branch -a --contains 3137334d7556e24e3f582681142e505b4d7915a8 includes 3137334d7556e24e3f582681142e505b4d7915a8 (2024-10-17)

15s

git clone --branch nixos-unstable --single-branch --no-checkout --shallow-since=2024-10-16 https://github.com/NixOS/nixpkgs.git nixpkgs

git branch -a --contains 3137334d7556e24e3f582681142e505b4d7915a8 does not include

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024 •
edited
Loading

--shallow-since=2024-10-10: NG

--shallow-since=2024-09-15: OK 40s

--shallow-since=2024-10-01: OK 29s

--shallow-since=2024-10-07: NG 20s

why...

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024

💭 can't read deepen_since...

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024

git/git@a460ea4#diff-557abde72c039bab998d6362dbf3ec44f57d59ee7aa0ab8b317f9a2b0a47f14fR110

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024

1m36s

git clone --branch nixos-unstable --single-branch --no-checkout --shallow-exclude=nixos-24.05 https://github.
com/NixOS/nixpkgs.git nixpkgs

OK

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024 

> du -h nixpkgs
4.0K    nixpkgs/.git/branches
8.0K    nixpkgs/.git/info
68K     nixpkgs/.git/hooks
4.0K    nixpkgs/.git/objects/info
573M    nixpkgs/.git/objects/pack
573M    nixpkgs/.git/objects
8.0K    nixpkgs/.git/refs/tags
8.0K    nixpkgs/.git/refs/heads
20K     nixpkgs/.git/refs
8.0K    nixpkgs/.git/logs/refs/heads
12K     nixpkgs/.git/logs/refs
20K     nixpkgs/.git/logs
574M    nixpkgs/.git
574M    nixpkgs

💭 large for cache

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024

💭 depth 1 and checking file content might be better...

@kachick
Copy link
Owner Author

kachick commented Nov 1, 2024 •
edited
Loading

depth 1 and checking file conten

19s

However this way cannot detect reverting merged commits...

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖(GH-846): https://github.com/NixOS/nixpkgs/tree/nixos-unstable looks like merged NixOS/nixpkgs@3137334

Repository owner deleted a comment from github-actions bot Nov 3, 2024
@kachick
Copy link
Owner Author

kachick commented Nov 3, 2024

https://nixpk.gs/pr-tracker.html?pr=329653 🙄

@kachick
Copy link
Owner Author

kachick commented Nov 3, 2024

https://www.reddit.com/r/NixOS/comments/u3hmpn/comment/i4poti7/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

@kachick
Copy link
Owner Author

kachick commented Nov 3, 2024

https://github.com/nix-community/hydra-check/blob/38031b1e67616e2be2f9a2b7606ade196a9964a7/src/hydra_check/arguments.py#L9-L25

@kachick
Copy link
Owner Author

kachick commented Nov 3, 2024

image

@kachick kachick mentioned this issue Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
🛸
Status: 🎉
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add notify action with nixpkgs update kachick/dotfiles
1 participant
@kachick