Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the training. #7

Open
Lzhushuai opened this issue Dec 27, 2019 · 1 comment
Open

About the training. #7

Lzhushuai opened this issue Dec 27, 2019 · 1 comment

Comments

@Lzhushuai
Copy link

Hi, It's a great work!
I did not run the code. But I suspect there may be a problem.
In the paper, the author said that in the multi-task training(ie.training with romantic sentences or humorous sentences) he only update the matrix set {S}. But in your code, the whole LSTM was updated. I didn't find that you frozen other matrixs in somewhere. am I right?
Thank you!

@kacky24
Copy link
Owner

kacky24 commented Jan 19, 2020

Hello.
I'm sorry for my late reply.

Your advice seems to be right.
I really appreciate it!!
I'll modify my mistake when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants