Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@tools-website] Home and faucet page UI fixes #1189

Merged
merged 19 commits into from
Nov 15, 2023
Merged

[@tools-website] Home and faucet page UI fixes #1189

merged 19 commits into from
Nov 15, 2023

Conversation

KristinaSpasevska
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b40d930

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 9:42pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 9:42pm
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 9:42pm
react-ui ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 9:42pm

@KristinaSpasevska KristinaSpasevska changed the title feat: minor ui fixes [@tools-website] Minor UI fixes Nov 7, 2023
@KristinaSpasevska KristinaSpasevska changed the title [@tools-website] Minor UI fixes [@tools-website] Home and faucet page UI fixes Nov 10, 2023
sanderlooijenga
sanderlooijenga reviewed Nov 13, 2023
View reviewed changes
packages/apps/tools/src/utils/persist.ts
}
};

export const deleteItem = (key: string) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity; Why are these deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were not used anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were they ever used? I think in this case these could stay in, as they could potentially be used later. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem to retrieve them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can run the formatter then that would be great, I'm approving in the meantime 😄

packages/apps/tools/src/utils/persist.ts Outdated Show resolved Hide resolved
packages/apps/tools/src/components/Global/AccountNameField/index.tsx Show resolved Hide resolved
packages/apps/tools/src/components/Common/Layout/partials/Sidebar/styles.css.ts Show resolved Hide resolved
@KristinaSpasevska KristinaSpasevska merged commit 680592c into main Nov 15, 2023
11 of 12 checks passed
@KristinaSpasevska KristinaSpasevska deleted the feat/tools-website/ui-fixes-on-sidebar branch November 15, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderlooijenga sanderlooijenga Awaiting requested review from sanderlooijenga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristinaSpasevska @sanderlooijenga @Ghislain89