[@kadena/client-utils] Implement Marmalade functions (Feat) #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🦋 Changeset detectedLatest commit: 26ec4e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nil-amrutlal
changed the title
…ent-utils/marmalade-functions
nil-amrutlal
commented
Jan 22, 2024
nil-amrutlal
commented
Jan 22, 2024
…#2055) * chore: added more maramalade util functions * chore: align create-token with other functions * fix: linting issues * feat: added sale functions and tests; chore: updated and cleaned read functions * chore: linting * chore: added script to setup test environment before executing integration tests * chore: lint setup marmalade test env file * chore: gnerate marmalade-v2.policy-manager types * chore: check if conventional and dutch auction have been whitelisted * chore: remove whitelisting sale from test setup script * chore: wait for block time helper function * chore: fix lint issue * chore: enforce failure uri guard if not updatable when using guard policy * chore: rename config to updatableURI * chore: remove guard on local calls * feat: added collection-policy functions * chore: adjust the auction end date in tests * chore: cleanup and stability improvements * fix: more time * chore: simplify local call functions * chore: linting
Ghislain89
reviewed
May 29, 2024
| @@ -3,6 +3,6 @@ import { defineConfig } from 'vitest/config'; | |||
| export default defineConfig({ | |||
| test: { | |||
| include: ['src/**/*.int.test.ts'], | |||
| testTimeout: 60000, | |||
| testTimeout: 150000, | |||
There was a problem hiding this comment.
Should be able to reduce this, due to instant mining sandbox
There was a problem hiding this comment.
can you please split the config for the functions need more times
nil-amrutlal
commented
May 29, 2024
Comment on lines
+51
to
+53
| policies: () => | ||
| policies.length > 0 ? `[${policies.join(' ')}]` : '[]', | ||
| }, |
There was a problem hiding this comment.
Does this work when tested with policies?
There was a problem hiding this comment.
Yeah, I have it also covered in a test here https://github.com/kadena-community/kadena.js/pull/1484/files#diff-c7b784837590ebd192b560bcca5c3bcd40cf90e640d56e4a6c166bf5fec1ae38R109
Ghislain89
approved these changes
May 29, 2024
javadkh2
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR has a dependency regarding the integration testing. It requires the container to have marmalade deployed. This feature will be developed and once it is. However, this PR can already be tested locally