From e79631ba403b7d4ba7905ba6f08b65e917f097d6 Mon Sep 17 00:00:00 2001 From: AmirDapl Date: Mon, 22 Jul 2024 10:37:41 -0500 Subject: [PATCH 1/2] Update conventional-auction.pact I was testing the new graphql looking to stream live auctions and bid information, then realized the BID_AUCTION capability was changed last update. Outside of this breaking existing indexer logic that requires performing local calls now, I am unclear what the harm in having this important data readily available? --- .../conventional-auction/conventional-auction.pact | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pact/sale-contracts/conventional-auction/conventional-auction.pact b/pact/sale-contracts/conventional-auction/conventional-auction.pact index 0f0a14fc..59221791 100644 --- a/pact/sale-contracts/conventional-auction/conventional-auction.pact +++ b/pact/sale-contracts/conventional-auction/conventional-auction.pact @@ -51,6 +51,8 @@ (defcap BID_PLACED:bool ( bid-id:string sale-id:string + bid:decimal + token-id:string ) @event true @@ -277,7 +279,7 @@ ) ) (update auctions sale-id { 'highest-bid: bid, 'highest-bid-id: bid-id }) - (emit-event (BID_PLACED bid-id sale-id)) + (emit-event (BID_PLACED bid-id sale-id bid token-id)) )) true ) From 0125679edb243da5c6114e69eab7a0c430e7e640 Mon Sep 17 00:00:00 2001 From: AmirDapl Date: Mon, 22 Jul 2024 10:39:32 -0500 Subject: [PATCH 2/2] Update conventional-auction.pact I was testing the new graphql looking to stream live auctions and bid information, then realized the BID_AUCTION capability was changed last update. Outside of this breaking existing indexer logic that requires performing local calls now, I am unclear what the harm in having this important data readily available? --- .../conventional-auction/conventional-auction.pact | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pact/sale-contracts/conventional-auction/conventional-auction.pact b/pact/sale-contracts/conventional-auction/conventional-auction.pact index 59221791..7850a560 100644 --- a/pact/sale-contracts/conventional-auction/conventional-auction.pact +++ b/pact/sale-contracts/conventional-auction/conventional-auction.pact @@ -52,6 +52,7 @@ ( bid-id:string sale-id:string bid:decimal + bidder:string token-id:string ) @event @@ -279,7 +280,7 @@ ) ) (update auctions sale-id { 'highest-bid: bid, 'highest-bid-id: bid-id }) - (emit-event (BID_PLACED bid-id sale-id bid token-id)) + (emit-event (BID_PLACED bid-id sale-id bid bidder token-id)) )) true )