-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(core): extend the grammar definition #103
base: master
Are you sure you want to change the base?
Conversation
This document reformats `Semantics.md` without changing its content. Signed-off-by: Luke Gareth Ribchester <[email protected]>
Signed-off-by: Luke Gareth Ribchester <[email protected]>
Signed-off-by: Luke Gareth Ribchester <[email protected]>
Hey @lukeribchester, thanks for the PR! Looks good so far, let me know what issues come up, because the current parser spec works against all the test files. |
Signed-off-by: Luke Gareth Ribchester <[email protected]>
Hey @jmcardon, thank you and apologies for my delayed reply. I've further refined the grammar definition based on my experiences working with it for the IntelliJ Platform plugin release, and I've separated most special characters from the identifier token definition into their respective definitions and categories. My parser now functions correctly against all test files except for |
This is currently in use in version |
Hi I'm sorry for the delayed reply! Pact-5 is just parsing this atm, and we amended the parse tree to work with this regression. |
This pull request extends the Pact grammar definition documented in
Semantics.md
.Draft: The current definition is approximately complete based on the current Pact 5 parser implementation,
but contains a few minor issues which are visible when testing against the Pact test files.These issues will be documented, discussed, and fixed here before merging this pull request.To Do
Pull Request Checklist