Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix.yml to latest setup-nix-with-cache [WIP] #1293

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

enobayram
Copy link
Contributor

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still a WIP?

@enobayram
Copy link
Contributor Author

@emilypi I believe it to be ready code-wise, but we still need to wait for the action run to complete (hopefully with success). Though I think it'll time out a couple of times as it builds and caches layers of Haskell tooling for the first time.

don't trigger this when just updating other workflows
@DevopsGoth
Copy link
Contributor

This workflow has performed under test several times now and should be correct. Merging it will fix current pact build times and provide nix caching for arm64 linux, arm64 mac, and M1 arm macs.

@DevopsGoth DevopsGoth merged commit 2a6e8ca into master Aug 30, 2023
3 checks passed
@DevopsGoth DevopsGoth deleted the enis/update-nix-ci branch August 30, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants