Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message as of React 0.14 #32

Open
ffxsam opened this issue Oct 29, 2015 · 13 comments
Open

Warning message as of React 0.14 #32

ffxsam opened this issue Oct 29, 2015 · 13 comments

Comments

@ffxsam
Copy link

ffxsam commented Oct 29, 2015

The react package has been updated to 0.14, and as a result, React.render is no longer valid. For React 0.14 and up, it should be ReactDOM.render.

@marbemac
Copy link

+1

@ffxsam
Copy link
Author

ffxsam commented Oct 29, 2015

I created a PR #33

@marbemac
Copy link

Ah, beat me to it!

@v3rron
Copy link

v3rron commented Oct 29, 2015

another error:
Warning: React.renderToStaticMarkup is deprecated. Please use ReactDOMServer.renderToStaticMarkup from require('react-dom/server') instead.

@ffxsam
Copy link
Author

ffxsam commented Oct 29, 2015

Good catch. Someone else wanna PR that one?

@ffxsam
Copy link
Author

ffxsam commented Oct 29, 2015

I checked for the new React via Package['react-runtime'].ReactDOM. I'm not sure if that's the best way or not, but it works. There's also Package['react-runtime'].React.version that could be regex'd.

@arunoda
Copy link
Contributor

arunoda commented Oct 30, 2015

@ffxsam we can simply give the latest version of the react package. So, we don't need to check for backward compatibility.

@ffxsam
Copy link
Author

ffxsam commented Oct 30, 2015

So you mean react-layout will now require react 0.14 and above?

@arunoda
Copy link
Contributor

arunoda commented Oct 30, 2015

Yes. I'll work on the PR :)

@arunoda
Copy link
Contributor

arunoda commented Oct 30, 2015

Check v1.5.0. it's has the latest React version.

We had to do few stuff to support SSR specially.
See: b2b67a5

@sahanDissanayake
Copy link

upgraded to the v1.5.0

these upgrades happen too

cosmos:browserify    upgraded from 0.5.1 to 0.8.1
kadira:react-layout  upgraded from 1.4.1 to 1.5.0
react                upgraded from 0.1.13 to 0.14.1
react-meteor-data    upgraded from 0.1.9 to 0.2.2
react-runtime        upgraded from 0.13.3_7 to 0.14.1
react-runtime-dev    upgraded from 0.13.3_7 to 0.14.1
react-runtime-prod   upgraded from 0.13.3_6 to 0.14.1

cosmos:browserify new upgrade slows the rebuild process.. Please look in to this too

@vladshcherbin
Copy link

I can also confirm the huge slow down in the rebuild process after browserify updated.

@stallter4
Copy link

I initally received the React.render not a function, removed the react package, then readded it, and now I am getting this console error:

VM1567:2 Uncaught SyntaxError: Unexpected token < in JSON at position 1xo.onfinish @ sockjs-0.3.4.js:2018EventEmitter.emit @ sockjs-0.3.4.js:151that.xhr.onreadystatechange @ sockjs-0.3.4.js:848

and this command line error:

while computing assigned variables: /packages/kadira_react-layout/packages/karia_react_layout.js: unexpected token: (69:12)

I think kadira:react-layout is broken. Any way to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants