-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failing #9
Comments
It's failing because the Meteor update to 1.4 broke the original Meteord, which this is forked from. It hasn't really been touched since the fork of the old version. Is there a timeline for when this will be usable with 1.4? |
If someone can give me some suggestions for the fix I can try my hand at a PR, but I'm a bit of a docker n00b and I could use some help digging around. |
Well the obvious change was updating Node, which has already been done. (See this commit) From there I think it's just a matter of trying to build it and running through the errors. Someone else might have a more precise idea of what needs fixing, though. There are also 2 outstanding PRs right now that seem to be necessary updates. |
@macsj200 I assume that it's not working because the pull request that fixed the code failed, if the big red FAILED sign on the main page is anything to go by, though to be honest I'm not exactly sure what the failed sign means. To get around the problem, and so that I could use Meteor 1.4, I cloned the current meteorhacks:meteord code to my machine and manually made the three changes from this page I then got docker-compose to build from my local copy, and it works, perfectly. Of course I would prefer for it to be fixed permanently, and use the dockerfile directly from here. |
Currently, CI says the latest build version is failing, what's up with that?
The text was updated successfully, but these errors were encountered: