Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing #9

Open
macsj200 opened this issue Aug 24, 2016 · 4 comments
Open

Build failing #9

macsj200 opened this issue Aug 24, 2016 · 4 comments

Comments

@macsj200
Copy link

Currently, CI says the latest build version is failing, what's up with that?

@gkrizek
Copy link

gkrizek commented Aug 24, 2016

It's failing because the Meteor update to 1.4 broke the original Meteord, which this is forked from. It hasn't really been touched since the fork of the old version.

Is there a timeline for when this will be usable with 1.4?

@macsj200
Copy link
Author

If someone can give me some suggestions for the fix I can try my hand at a PR, but I'm a bit of a docker n00b and I could use some help digging around.

@gkrizek
Copy link

gkrizek commented Aug 25, 2016

Well the obvious change was updating Node, which has already been done. (See this commit)

From there I think it's just a matter of trying to build it and running through the errors. Someone else might have a more precise idea of what needs fixing, though. There are also 2 outstanding PRs right now that seem to be necessary updates.

@mwarren2
Copy link

mwarren2 commented Aug 28, 2016

@macsj200 I assume that it's not working because the pull request that fixed the code failed, if the big red FAILED sign on the main page is anything to go by, though to be honest I'm not exactly sure what the failed sign means.

To get around the problem, and so that I could use Meteor 1.4, I cloned the current meteorhacks:meteord code to my machine
git clone https://github.com/meteorhacks/meteord.git

and manually made the three changes from this page
[https://github.com/meteorhacks/pull/108/files] in the copy on my machine.

I then got docker-compose to build from my local copy, and it works, perfectly.

Of course I would prefer for it to be fixed permanently, and use the dockerfile directly from here.
Because it looks as if they're going to leave meteorhacks:meteord at 1.3, and have kadirahq:meteord here running 1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants