Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No access to patch coordinates #673

Open
nkaenzig opened this issue Oct 9, 2024 · 0 comments · May be fixed by #674
Open

No access to patch coordinates #673

nkaenzig opened this issue Oct 9, 2024 · 0 comments · May be fixed by #674
Assignees

Comments

@nkaenzig
Copy link
Collaborator

nkaenzig commented Oct 9, 2024

As for now, after running an evaluation there is no information in the generated outputs/logs about the patch coordinates that were used. For better reproducibility & transparency, we should make this information available.

One possible solution could be to add the patch coordinates to manifest file generated by the embeddings writers.

@nkaenzig nkaenzig self-assigned this Oct 9, 2024
@nkaenzig nkaenzig linked a pull request Oct 9, 2024 that will close this issue
@nkaenzig nkaenzig linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant