Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release or tag for 5.0.0? #65

Open
GNUtoo opened this issue May 10, 2023 · 0 comments
Open

New release or tag for 5.0.0? #65

GNUtoo opened this issue May 10, 2023 · 0 comments

Comments

@GNUtoo
Copy link

GNUtoo commented May 10, 2023

Hi,

cpp-mustache 4.1 doesn't build anymore with newer toolchains (like the one in Guix, a GNU/Linux distribution):

  • Catch2 doesn't compile anymore due to some changes in glibc, it was fixed by updating catch2 in later commits
  • There are undefined variables that were fixed in later commits

So it looks like a new release is needed at some point somehow. But I don't understand if there was one already or not.

Does the commit 4ed8c0b5a2a43d59394bd6900dc04e738dbf8c02 (Set version to 5.0.0) correspond to a new release, or is it just some semver-like API change?

If 4ed8c0b is a new release, it would be a good idea to add a release tag to make sure that people (and automatic tools) can understand that therew as a new release.

If there is no new release would packaging 4ed8c0b instead be a better idea than backporting catch2 and undefined variable fixes? The later has the issue that (an outdated version of) catch2 2.x is still bundled in while in 4ed8c0b the system catch2 (2.x?) seems to be used instead.

My use case is to fix the kiwix-tools package in Guix that depends on cpp-mustache.

Anyway, thanks a lot for having fixed all the issues (like making it compile on newer compilers, getting rid of bundled in libraries and so on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant