Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping the upgrade image verification in UKI mode #2634

Open
jimmykarily opened this issue Jun 18, 2024 · 1 comment
Open

Allow skipping the upgrade image verification in UKI mode #2634

jimmykarily opened this issue Jun 18, 2024 · 1 comment

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented Jun 18, 2024

In order to check the validity of the upgrade images, we load the whole artifact into memory. With big enough images and low enough memory, this makes the upgrade process die with "OOM killed".

In cases like this, it would be good if we allowed the user to perform this checks out-of-band and make this check optional (skip it with a flag). This would allow people to install in low-memory machines.

@jimmykarily jimmykarily converted this from a draft issue Jun 18, 2024
@jimmykarily jimmykarily added the triage Add this label to issues that should be triaged and prioretized in the next planning call label Jun 18, 2024
@jimmykarily
Copy link
Contributor Author

We should give a try to the go-uefi peparser to see if it handles this better.

@jimmykarily jimmykarily removed the triage Add this label to issues that should be triaged and prioretized in the next planning call label Jun 25, 2024
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Jun 25, 2024
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 🖊
Development

No branches or pull requests

1 participant