-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device json schema to allow other device paths #2906
Comments
Hi, can I work on this bug? |
By all means @HariniKrishnan! Give it a shot. If it takes too long we may have to pick it up within the core team to unblock people though. |
@jimmykarily When are we expecting the code, can I take a week's time? |
Sure thing @HariniKrishnan ! Thank you 💯 |
@HariniKrishnan I'll assign you to the ticket, it's not to put any pressure but just to also see it on the dashboard that someone is on it. If you need help or more time, just let us know. Thanks! |
@mauromorales thanks a lot! |
whom should I reach out to for doubts reg this issue? |
@HariniKrishnan I'd say the slack channel is probably the best place because then whoever in the team looks at it and knows, can start helping. Just keep in mind for the replies that we are mostly in EU timeline |
[email protected] is my email!!! can you please add me to you workspace! |
You need to get a self-invitation here: https://slack.cncf.io/#kairos |
Hey @jimmykarily Any idea when this might get fixed? |
We planned it for the last sprint but nobody got a chance to fix it. Let's hope we get this done this week. |
E.g. /dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0 Part of kairos-io/kairos#2906 Signed-off-by: Dimitris Karakasilis <[email protected]>
* Fix install.device schema to allow all devices E.g. /dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0 Part of kairos-io/kairos#2906 Signed-off-by: Dimitris Karakasilis <[email protected]> * Add test and run `go mod tidy` Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix test Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]>
The fix got merged in the kairos-agent. We just need to cut a new release of kairos-agent and kairos to make it consumable. |
@jimmykarily, did this get released in 3.2.2? I don't see a mention of it so I'm assuming not. |
Yes the fix is in 3.2.2, I updated the release notes to say so (the first item in the list). |
sorry, we did a mistake and we didn't bump the kairos-agent in the latest framework image 🤦 . Please wait for 3.2.3 (coming soon) |
This should be fixed. I'll close but feel free to re-open if you face any issues. |
After this: kairos-io/kairos-agent#552
we should now update the schema to allow these new paths: https://github.com/kairos-io/kairos-sdk/blob/156caa6f8c9066b99417912a572285c33ab44b3c/schema/install_schema.go#L14
Auroraboot fails with this if we don't:
Device used in original report:
/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0
The text was updated successfully, but these errors were encountered: