Skip to content

Commit

Permalink
Revert "Add automatic notification about js API change on install"
Browse files Browse the repository at this point in the history
`npm` since `v7` doesn't display the output of lifecycle scripts (see
https://docs.npmjs.com/cli/v9/using-npm/logging?v=true#foreground-scripts),
so the automatic notification no longer works. The note in README will
have to suffice.

This reverts commit 1be1580.
  • Loading branch information
generalmimon committed Oct 21, 2023
1 parent 1be1580 commit 40a4ba4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
5 changes: 1 addition & 4 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,9 @@ lazy val buildNpmPackageTask = Def.task {
val licenseFile = new File("js/npm/LICENSE")
val readMeFile = new File("js/npm/README.md")
val packageJsonFile = new File("js/npm/package.json")
val warnFile = new File("js/npm/warn-about-constructor-bc-break.js")

Files.copy(new File("LICENSE").toPath, licenseFile.toPath)
Files.copy(new File("js/README.md").toPath, readMeFile.toPath)
Files.copy(new File("js/warn-about-constructor-bc-break.js").toPath, warnFile.toPath)

val packageJsonTmpl = IO.read(new File("js/package.json"), UTF8)
val packageJsonContents = packageJsonTmpl.replaceFirst(
Expand All @@ -266,7 +264,6 @@ lazy val buildNpmPackageTask = Def.task {
Seq(
licenseFile,
readMeFile,
packageJsonFile,
warnFile,
packageJsonFile
)
}
1 change: 0 additions & 1 deletion js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"url": "git+https://github.com/kaitai-io/kaitai_struct_compiler.git"
},
"scripts": {
"postinstall": "node warn-about-constructor-bc-break.js",
"test": "echo \"Error: no test specified\" && exit 1"
},
"version": "OVERRIDDEN BY /build.sbt"
Expand Down
5 changes: 0 additions & 5 deletions js/warn-about-constructor-bc-break.js

This file was deleted.

0 comments on commit 40a4ba4

Please sign in to comment.