Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building error #14

Closed
Ruslan0Dev opened this issue Aug 1, 2021 · 6 comments · Fixed by #15
Closed

building error #14

Ruslan0Dev opened this issue Aug 1, 2021 · 6 comments · Fixed by #15
Labels

Comments

@Ruslan0Dev
Copy link

I tried to compile but got the error:
image

@generalmimon
Copy link
Member

Cc @Mingun

@GreyCat
Copy link
Member

GreyCat commented Aug 3, 2021

With sunset of bintray, it looks like we'll have to republish JHexView to some other place... Or, better yet, have somebody take ownership of that code and start publishing that to proper public repos (e.g. Central Maven).

@Mingun
Copy link
Contributor

Mingun commented Aug 4, 2021

Or, better yet, have somebody take ownership of that code and start publishing that to proper public repos (e.g. Central Maven).

I think that would be the best option. I can't find any way to publish an artefact without gpg magic and very confusing guides. So if you already have working account to publish to Maven Central I'll be glad to provide you all required access. Otherwise I have to learn gpg and maven publish plugins...

@GreyCat
Copy link
Member

GreyCat commented Aug 4, 2021

@Mingun Central Maven's access is granted on per-domain org, so we've got one registered for io.kaitai (given that we own https://kaitai.io/).

To publish JHexView using that, at bare minimum JHexView code has to be refactored to use io.kaitai namespace - so, effectively, we're talking about a fork of https://github.com/sporst/JHexView ?

@dgelessus
Copy link

To publish JHexView using that, at bare minimum JHexView code has to be refactored to use io.kaitai namespace

I don't think the code needs to be changed - it doesn't contain references to any specific Maven group ID, right? The library's package is called tv.porst.jhexview, but you can still upload it under the io.kaitai group - there's no requirement that the Java package name matches the Maven group ID.

@Mingun
Copy link
Contributor

Mingun commented Aug 8, 2021

To publish JHexView using that, at bare minimum JHexView code has to be refactored to use io.kaitai namespace - so, effectively, we're talking about a fork of https://github.com/sporst/JHexView ?

No, as @dgelessus said, you can just republish project under the new group id. If you need my assistance as JHexView project owner (because this fork is used in this project) to integrate these changes into the repository, I would glade to cooperate.

I also want to note to everyone interested that the further development of this project is difficult without the adoption of kaitai-io/kaitai_struct_compiler#191, kaitai-io/kaitai_struct_java_runtime#28 and related.

Mingun added a commit to Mingun/kaitai_struct_gui that referenced this issue Oct 26, 2021
Mingun added a commit to Mingun/kaitai_struct_gui that referenced this issue Oct 26, 2021
generalmimon added a commit that referenced this issue Oct 28, 2021
Switch from Bintray to JitPack. Fixes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants