Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom modifier applied twice when applied to Druid Wildshape dice rolls #1074

Open
ArsonKoala opened this issue Jul 23, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ArsonKoala
Copy link

When using custom modifiers (i.e. +1 magic bonus, +1d4 from bless) on dice rolls in Wildshape stat block, modifier being applied twice (+1+1 instead of +1, +1d4+1d4 instead of +1d4)

To Reproduce
Go to character sheet, open extras, click desired wildshape to open statblock on right display, apply custom modifier either through beyond20 dropdown or custom hotkey, click dice roll button.

Expected behavior
If custom modifier is +1 to roll or +1 to damage, should be applying +1 not +1+1.

Browser Info (please complete the following information):

  • Firefox
  • 115.0.2

Additional context
Add any other context about the problem here, such as a link to the character sheet or D&D Beyond page that shows the problem.

@ArsonKoala ArsonKoala added the bug Something isn't working label Jul 23, 2023
@kakaroto
Copy link
Owner

kakaroto commented Jul 23, 2023

I'm not seeing that behavior when using custom modifiers configured on the character sheet
image
But if I use a hotkey, I do see it:
image

Note: Using the hotkeys applies the modifiers to non-wildshape extras too (but doesn't apply twice), so my guess is that the recent update which added support for custom modifiers in wildshape is applying both character sheet modifiers and hotkey modifiers. It should only apply character sheet modifiers since hotkey modifiers will already apply from elsewhere in the code.

@kakaroto kakaroto added this to the 2.10.0 milestone Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants