-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main.html template #27
Comments
We should have a page.html template like pinnacle has for all generic pages. We shouldn't need templates for every page, but will most likely for most. |
This is correct we should have article pages that follow the same patterns use "article.html", have the templates be pages, and defining what our base templates would be should be pretty straightforward and prioritized. Looks like in general we're looking towards using Atomic patterns: Defining/Building layouts ought to be pretty straightforward, mostly a question of planning/documenting: A couple of obvious ones: We'll want to try and name our layouts semantically so we're not just describing desktop arrangements, but naming use-cases. |
Every time I've added a new page I've duplicated an existing template and renamed it so we've ended up with a few templates that all have the same markup, just different names:
This could just stem from the fact that I wasn't familiar enough with the previous implementation—but it seems a bit redundant.
This relates to #23 where I'm questioning the use of the article tag as a wrapper for everything but my proposal is that we have a main.html to contain the markup above and then each page can use that as it's template and any page that needs any different wrapping markup can define a new one e.g. main-articles.html or similar.
The text was updated successfully, but these errors were encountered: