Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.html template #27

Closed
soniktrooth opened this issue Jan 9, 2015 · 4 comments
Closed

main.html template #27

soniktrooth opened this issue Jan 9, 2015 · 4 comments
Milestone

Comments

@soniktrooth
Copy link
Contributor

Every time I've added a new page I've duplicated an existing template and renamed it so we've ended up with a few templates that all have the same markup, just different names:

{% extends 'html.html' %}

  {% block contents %}

  <main role="main">
    <article> 
      {{contents|safe}}
    </article>
  </main>

  {% endblock %}

This could just stem from the fact that I wasn't familiar enough with the previous implementation—but it seems a bit redundant.

This relates to #23 where I'm questioning the use of the article tag as a wrapper for everything but my proposal is that we have a main.html to contain the markup above and then each page can use that as it's template and any page that needs any different wrapping markup can define a new one e.g. main-articles.html or similar.

@andrewmallis
Copy link
Member

We should have a page.html template like pinnacle has for all generic pages.
The page-name.md can then reference that template.

We shouldn't need templates for every page, but will most likely for most.
Feeling we might need some group convo on this and brainstorming.

@thiagodemellobueno
Copy link
Contributor

@andrewmallis andrewmallis modified the milestone: 1.0 Jan 13, 2015
@thiagodemellobueno
Copy link
Contributor

This is correct we should have article pages that follow the same patterns use "article.html", have the templates be pages, and defining what our base templates would be should be pretty straightforward and prioritized.

Looks like in general we're looking towards using Atomic patterns:
http://bradfrost.com/blog/post/atomic-web-design/#templates
Atoms > Molecules > Organisms makes lots of sense, and building templates from organisms lends itself well to our approach so far.

Defining/Building layouts ought to be pretty straightforward, mostly a question of planning/documenting:

A couple of obvious ones:

TwoColContentFirst
two-col-content-first

TwoColSidebarFirst
two-col-sidebar-first

HeroThreeTouts
hero-three-touts

We'll want to try and name our layouts semantically so we're not just describing desktop arrangements, but naming use-cases.

@thiagodemellobueno thiagodemellobueno removed their assignment Dec 15, 2016
@RobLoach
Copy link
Contributor

RobLoach commented Mar 6, 2017

#414

@RobLoach RobLoach closed this as completed Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants