Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal UI Improvement Thread #192

Open
audsssy opened this issue Apr 26, 2022 · 1 comment
Open

Proposal UI Improvement Thread #192

audsssy opened this issue Apr 26, 2022 · 1 comment

Comments

@audsssy
Copy link
Collaborator

audsssy commented Apr 26, 2022

Purpose of this thread is to identify a checklist of tasks per proposal, mostly as a reminder as I revamp proposal UIs 😛 Rather than creating multiple issues per proposal, I'm consolidating them all into one place for simplicity. Feel free to comment in this thread of any proposal related UI/UX suggestions and I will edit this instant post.

Payment (SendToken.js)

  • Must check payment amount of any ERC20 against DAO balance prior to submitting payment proposal

NFTs (SendNFT.js)

  • Must check that DAO holds NFTs prior to submitting NFT proposal

CALL (ContractCall.js)

  • Allow interacting with Read functions instead of redirecting to Etherscan
  • Add some sort of check (if possible) ahead of submitting CALL prop to see if proposal may actually be processed when passed as it's poor UX when CALL prop can be submitted but cannot be processed
@nerderlyne
Copy link
Contributor

@audsssy for CALL (2) we should simulate the proposal being submitted -> passed -> processed using tenderly or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants