Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting settings not behaving as users expect #250

Open
ivelin opened this issue Aug 5, 2022 · 3 comments
Open

Voting settings not behaving as users expect #250

ivelin opened this issue Aug 5, 2022 · 3 comments

Comments

@ivelin
Copy link
Collaborator

ivelin commented Aug 5, 2022

Problem

There seems to be a disconnect between the expectations that users have with voting settings in the UI and the consequent behavior of the contract and UI. Here is a thread related to a situation where users set 75% supermajority parameter but it turned out the contract uses simple majority rule.
https://discord.com/channels/923399898769018921/925091695677309059/1005085447720014005

Solution

  • Reconsider UI flow for voting parameter settings at new DAO deployment.
  • Expose more clearly the current voting rules in the UI.
  • Allow users to adjust settings in UI
  • Write 100% unit test coverage for governance functions in the UI.
  • Write 100% unit test coverage for subgraph scripts related to governance functions.
  • Write 100% unit test coverage for smart contract functions related to governance.
@ivelin ivelin changed the title Initial voting settings initialization confusing Voting settings not behaving as users expect Aug 5, 2022
@nerderlyne
Copy link
Contributor

Governance settings for proposals are set more in line with user expectation and behaviour now. I don't think this was the case at the time Sporos was deployed.

https://github.com/kalidao/kali-ui/blob/main/components/deploy-dao/checkout/index.js see 142

@nerderlyne
Copy link
Contributor

What flow would you suggest for governance settings specifically?

I am interested in converting the flow to a page with templates(entity + gov settings + extensions). This will also tie in with a guide expanding on each template.

@ivelin
Copy link
Collaborator Author

ivelin commented Aug 5, 2022

What flow would you suggest for governance settings specifically?

I am interested in converting the flow to a page with templates(entity + gov settings + extensions). This will also tie in with a guide expanding on each template.

Good question. I pinged our UX gigabrains to chime in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants