You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found a rather serious bug.
It occurs when:
-- fill: fade;
-- the mini-graph-card is placed inside a custom:decluttering-card;
-- there are at least 2 cards on the view with different height.
-- using Safari (observed in MacOS 10.x & iOS 15.x) or iOS Companion App.
Here is a code for a decluttering template (put your own sensor):
The view contains 2 stacks:
-- two mini-graph-card inside declutering-card - with different heights;
-- two mini-graph-card - with different heights.
How it looks in Chrome+Win:
And how it looks in Safari:
There is a glitch on the top-left card - the "fill" seems to occupy just a half of the area.
As a workaround - use "fill: true".
Or do not use Safari & iOS Companion App.
A possible reason is described below.
The graph contains of three objects:
-- the graph's line;
-- the graph's points;
-- the graph's fill.
If the card contains several entities - then it contains several sets of those objects (line, points, fill).
To differ objects belonging to different entities, the code uses a unique ID:
containing a unique string and some index (0 - 1st entity, 1 - 2nd entity, ...).
The unique string seems to be some kind of "this card unique ID".
But when placed inside a decluttering-card, these IDs are same:
The declutter-child- part is always same. Means - if several cards are present on the view, a wrong fill mask may be selected.
A possible fix should be generating a unique ID.
The text was updated successfully, but these errors were encountered:
ildar170975
changed the title
Safari: glitches when "fill: fade" & using "decluttering-card"
Safari, iOS Compainion App: glitches when "fill: fade" & using "decluttering-card"
Sep 23, 2022
ildar170975
changed the title
Safari, iOS Compainion App: glitches when "fill: fade" & using "decluttering-card"
Safari, iOS Companion App: glitches when "fill: fade" & using "decluttering-card"
Sep 23, 2022
Issue is caused by decluttering-card overriding the random id to a hardcodeddeclutter-child, breaking the HTML compliance of the page (ids must be unique)
I recommend raising an issue there pointing to the line/including this comment; it can set it's own id (would actually be beneficial in several cases); however there should still be a unique part of the id (f.e. declutter-child-<instance#>)
Absolutely agree - this is a decluttering-card issue.
Unfortunately, the repo seems to be abandoned.
And the author does not respond...
OK, we'll keep using fill: true as a workaround.
Found a rather serious bug.
It occurs when:
--
fill: fade
;-- the
mini-graph-card
is placed inside acustom:decluttering-card
;-- there are at least 2 cards on the view with different
height
.-- using Safari (observed in MacOS 10.x & iOS 15.x) or iOS Companion App.
Here is a code for a decluttering template (put your own sensor):
and for the test view:
The view contains 2 stacks:
-- two
mini-graph-card
insidedeclutering-card
- with different heights;-- two
mini-graph-card
- with different heights.How it looks in Chrome+Win:
And how it looks in Safari:
There is a glitch on the top-left card - the "fill" seems to occupy just a half of the area.
As a workaround - use "fill: true".
Or do not use Safari & iOS Companion App.
A possible reason is described below.
The graph contains of three objects:
-- the graph's line;
-- the graph's points;
-- the graph's fill.
If the card contains several entities - then it contains several sets of those objects (line, points, fill).
To differ objects belonging to different entities, the code uses a unique ID:
containing a unique string and some index (0 - 1st entity, 1 - 2nd entity, ...).
The unique string seems to be some kind of "this card unique ID".
But when placed inside a
decluttering-card
, these IDs are same:The
declutter-child-
part is always same.Means - if several cards are present on the view, a wrong fill mask may be selected.
A possible fix should be generating a unique ID.
The text was updated successfully, but these errors were encountered: