Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to turn off trigger detection within settings.yml #325

Closed
ghost opened this issue Aug 23, 2017 · 6 comments
Closed

Possibility to turn off trigger detection within settings.yml #325

ghost opened this issue Aug 23, 2017 · 6 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2017

For those who use Kalliope with REST API only trigger detection / hotword detection makes no sense at all, this holds for a planned server / client infrastructure too, see #228

@Sispheor Sispheor changed the title Possibility to turn of trigger detection within settings.yml Possibility to turn off trigger detection within settings.yml Aug 23, 2017
@Sispheor
Copy link
Member

And why it's a big deal to let it start anyway?

@ghost
Copy link
Author

ghost commented Aug 25, 2017

If server / client infrastructure is available users will probably ask for it as Kalliope is used as a backend which is meant to return answers only or initiate some actions like home automation.

The issue sone of us observed with stability of Kalliope on some systems has a good workaround but probably was due to concurring audio where in my case Kalliope audio should be redundant.

I didn't wrote that it's a big deal or should have a high or even medium priority, only that waiting for a hotword trigger is redundant if there will definitely no one.

I was not considering any CPU resources which Snowboy consumes here, i don't think that it's of any significance.

@bacardi55
Copy link
Contributor

@1account would this feature answer your need?
I mean, starting kalliope muted is a bit the same as what you describe (except for the CPU used I guess) ?

@Sispheor
Copy link
Member

I think not. Muted means that kalliope will not speaks out loud when processing a neuron.

Here, the feature is to disable the trigger process (snowboy).

@bacardi55
Copy link
Contributor

Isn't it what mute does (put snowboy process on pause) ?
I see here https://github.com/kalliope-project/kalliope/blob/master/kalliope/signals/order/order.py#L237

        if muted:
            self.trigger_instance.pause()
            self.is_trigger_muted = True
            Utils.print_info("Kalliope now muted")

I guess it doesn't disable it per say though :)

FWIW: I worked on #376 via this PR if it's "enough" for now (as I think this real "disable snowboy" will only happen when moving to the server/client architecture)

@Sispheor
Copy link
Member

@1account I think the last feature made by @bacardi55 should be what you wanted.
And indeed we cannot do more so far.

Hope it help anyway. Tell us if we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants