From 3af730d9a73a207e41c27687dccb8155f777eda5 Mon Sep 17 00:00:00 2001 From: SivanA-Kaltura <88330203+SivanA-Kaltura@users.noreply.github.com> Date: Wed, 21 Aug 2024 17:50:40 +0300 Subject: [PATCH 1/4] append playkit-video-filter element --- src/player.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/player.ts b/src/player.ts index ff8b733e..76aaa59e 100644 --- a/src/player.ts +++ b/src/player.ts @@ -77,6 +77,14 @@ const CONTAINER_CLASS_NAME: string = 'playkit-container'; */ const POSTER_CLASS_NAME: string = 'playkit-poster'; +/** +/** +* The video filter class name. +* @type {string} +* @const +*/ +const VIDEO_FILTER_CLASS_NAME: string = 'playkit-video-filter'; + /** * The engine class name. * @type {string} @@ -1803,6 +1811,10 @@ export default class Player extends FakeEventTarget { * @returns {void} */ private _appendDomElements(): void { + // Append playkit-video-filter + const videoFilter = Utils.Dom.createElement('div'); + Utils.Dom.addClassName(videoFilter, VIDEO_FILTER_CLASS_NAME); + Utils.Dom.appendChild(this._el, videoFilter); // Append playkit-black-cover this._blackCoverEl = Utils.Dom.createElement('div'); Utils.Dom.addClassName(this._blackCoverEl, BLACK_COVER_CLASS_NAME); From 85bf217a1447e630c47a0c357f383c2773681196 Mon Sep 17 00:00:00 2001 From: SivanA-Kaltura <88330203+SivanA-Kaltura@users.noreply.github.com> Date: Mon, 26 Aug 2024 11:54:58 +0300 Subject: [PATCH 2/4] remove unused line --- src/player.ts | 49 ++++++++++++++++++++++++------------------------- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/src/player.ts b/src/player.ts index 76aaa59e..605b47f3 100644 --- a/src/player.ts +++ b/src/player.ts @@ -78,11 +78,10 @@ const CONTAINER_CLASS_NAME: string = 'playkit-container'; const POSTER_CLASS_NAME: string = 'playkit-poster'; /** -/** -* The video filter class name. -* @type {string} -* @const -*/ + * The video filter class name. + * @type {string} + * @const + */ const VIDEO_FILTER_CLASS_NAME: string = 'playkit-video-filter'; /** @@ -1263,16 +1262,16 @@ export default class Player extends FakeEventTarget { */ public getTracks(type?: TrackTypes): T[] { switch (type) { - case TrackType.VIDEO: - return Utils.Object.copyDeep(this._getVideoTracks()); - case TrackType.AUDIO: - return Utils.Object.copyDeep(this._getAudioTracks()); - case TrackType.TEXT: - return Utils.Object.copyDeep(this._getTextTracks()); - case TrackType.IMAGE: - return Utils.Object.copyDeep(this._getImageTracks()); - default: - return Utils.Object.copyDeep(this._tracks); + case TrackType.VIDEO: + return Utils.Object.copyDeep(this._getVideoTracks()); + case TrackType.AUDIO: + return Utils.Object.copyDeep(this._getAudioTracks()); + case TrackType.TEXT: + return Utils.Object.copyDeep(this._getTextTracks()); + case TrackType.IMAGE: + return Utils.Object.copyDeep(this._getImageTracks()); + default: + return Utils.Object.copyDeep(this._tracks); } } @@ -2027,7 +2026,7 @@ export default class Player extends FakeEventTarget { if (window.self !== window.top) { const head = Utils.Dom.getElementBySelector('head'); let title = head.querySelector('title'); - if (!title){ + if (!title) { title = Utils.Dom.createElement('title'); head.appendChild(title); } @@ -2732,15 +2731,15 @@ export default class Player extends FakeEventTarget { return; } switch (callbackType) { - case LabelOptions.QUALITIES: - this._setTracksCustomLabels(this._getVideoTracks(), customLabels[callbackType]); - break; - case LabelOptions.AUDIO: - this._setTracksCustomLabels(this._getAudioTracks(), customLabels[callbackType]); - break; - case LabelOptions.CAPTIONS: - this._setTracksCustomLabels(this._getTextTracks(), customLabels[callbackType]); - break; + case LabelOptions.QUALITIES: + this._setTracksCustomLabels(this._getVideoTracks(), customLabels[callbackType]); + break; + case LabelOptions.AUDIO: + this._setTracksCustomLabels(this._getAudioTracks(), customLabels[callbackType]); + break; + case LabelOptions.CAPTIONS: + this._setTracksCustomLabels(this._getTextTracks(), customLabels[callbackType]); + break; } } } From b27ad1434981d8366fe20acca9ef257cebef977a Mon Sep 17 00:00:00 2001 From: SivanA-Kaltura <88330203+SivanA-Kaltura@users.noreply.github.com> Date: Mon, 26 Aug 2024 11:56:25 +0300 Subject: [PATCH 3/4] remove auto indent --- src/player.ts | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/player.ts b/src/player.ts index 605b47f3..cdf1f87a 100644 --- a/src/player.ts +++ b/src/player.ts @@ -1262,16 +1262,16 @@ export default class Player extends FakeEventTarget { */ public getTracks(type?: TrackTypes): T[] { switch (type) { - case TrackType.VIDEO: - return Utils.Object.copyDeep(this._getVideoTracks()); - case TrackType.AUDIO: - return Utils.Object.copyDeep(this._getAudioTracks()); - case TrackType.TEXT: - return Utils.Object.copyDeep(this._getTextTracks()); - case TrackType.IMAGE: - return Utils.Object.copyDeep(this._getImageTracks()); - default: - return Utils.Object.copyDeep(this._tracks); + case TrackType.VIDEO: + return Utils.Object.copyDeep(this._getVideoTracks()); + case TrackType.AUDIO: + return Utils.Object.copyDeep(this._getAudioTracks()); + case TrackType.TEXT: + return Utils.Object.copyDeep(this._getTextTracks()); + case TrackType.IMAGE: + return Utils.Object.copyDeep(this._getImageTracks()); + default: + return Utils.Object.copyDeep(this._tracks); } } @@ -2731,15 +2731,15 @@ export default class Player extends FakeEventTarget { return; } switch (callbackType) { - case LabelOptions.QUALITIES: - this._setTracksCustomLabels(this._getVideoTracks(), customLabels[callbackType]); - break; - case LabelOptions.AUDIO: - this._setTracksCustomLabels(this._getAudioTracks(), customLabels[callbackType]); - break; - case LabelOptions.CAPTIONS: - this._setTracksCustomLabels(this._getTextTracks(), customLabels[callbackType]); - break; + case LabelOptions.QUALITIES: + this._setTracksCustomLabels(this._getVideoTracks(), customLabels[callbackType]); + break; + case LabelOptions.AUDIO: + this._setTracksCustomLabels(this._getAudioTracks(), customLabels[callbackType]); + break; + case LabelOptions.CAPTIONS: + this._setTracksCustomLabels(this._getTextTracks(), customLabels[callbackType]); + break; } } } From e11596f2c05176d8a16e4c4dcb19d44543e0cea2 Mon Sep 17 00:00:00 2001 From: SivanA-Kaltura <88330203+SivanA-Kaltura@users.noreply.github.com> Date: Mon, 26 Aug 2024 11:57:32 +0300 Subject: [PATCH 4/4] remove auto format --- src/player.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/player.ts b/src/player.ts index cdf1f87a..7a0d099c 100644 --- a/src/player.ts +++ b/src/player.ts @@ -2026,7 +2026,7 @@ export default class Player extends FakeEventTarget { if (window.self !== window.top) { const head = Utils.Dom.getElementBySelector('head'); let title = head.querySelector('title'); - if (!title) { + if (!title){ title = Utils.Dom.createElement('title'); head.appendChild(title); }