FOUN-1910: doSelectStmt does not use query cache so use doSelect and … #12857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iterate over object to return the ids
amiras89
reviewed
Aug 28, 2024
| $result = UserEntryPeer::doSelect($userEntryCriteria); | ||
|
|
||
| $ids = array(); | ||
| foreach ($result as $res) { |
There was a problem hiding this comment.
We probably want to put the curly brackets at the next line
Other then that looks OK
amiras89
approved these changes
Aug 28, 2024
amiras89
reviewed
Aug 28, 2024
| if($filter) | ||
| $filter->attachToCriteria($userEntryCriteria); | ||
|
|
There was a problem hiding this comment.
I prefer the extra line break, just for esthetics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iterate over object to return the ids