Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: release-images building occurs on the last commit rather than on the version commit #1049

Open
s373r opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@s373r
Copy link
Member

s373r commented Jan 29, 2025

Context

As part of the latest build, an unexpected situation occurred: the image with migrations (sqlx-cli-with-migrations) included migrations that are not related to the release.

Commits Timeline:

(from old to new)

Analysis

  • When releasing v0.220.0, (release CI workflow) extracted the repository revision that relates to the version (everything is as it should be)
  • release-images & release-test-installer CI workflows work a bit differently: they wait for release to completed and only then run themselves:
    • workflow_run:
        workflows:
          - release
        types:
          - completed
  • Thus, the latest code revision will be used (includes 1040 prototype email gateway changes), instead of the expected version revision

Expectations

  • Ensure that release-images & release-test-installer CI workflow are executed on the expected code revision

Next steps

We have a mirror situation in kamu-data/kamu-node#178, hence the solution found should be applied in kamu-node repository as well

@s373r s373r added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Jan 29, 2025
@s373r s373r self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

1 participant