Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit watermarks in RETH datasets #23

Open
sergiimk opened this issue Sep 25, 2024 · 1 comment
Open

Explicit watermarks in RETH datasets #23

sergiimk opened this issue Sep 25, 2024 · 1 comment

Comments

@sergiimk
Copy link
Member

sergiimk commented Sep 25, 2024

Rocketpool's tokens-minted dataset have not been producing new data points as token was saturated. The problem is that when data is not flowing we also don't update the watermark.

This ticket is to update the datasets to write explicit watermarks sourced from latest block's timestamps. Containerized ingest protocol should be updated accordingly to support this if needed.

@sergiimk
Copy link
Member Author

Original description was:

Rocketpool had a big Houston upgrade in June and since then tokens-minted dataset stopped producing any data points.

We should investigate how to support the new version.

Investigation confirmed that this is valid - no new tokens have actually been minted due to RETH deposit pool being saturated. RETH is currently being traded on Balancer and Uniswap, but not currently minted.

The problem here is that our current datasets don't update watermark when data is not flowing. We should rectify this by writing watermark sourced from the latest block's timestamp. Updating the ticket description accordingly.

@sergiimk sergiimk changed the title RETH dataset needs an update Explicit watermarks in RETH datasets Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant