Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (UI): Correct Zoom Button Order #725

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

leherkom
Copy link
Contributor

Pull request

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Please describe your changes

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Reorders the buttons for the zoom adjustment such that decreasing zoom is placed on the left and increasing zoom is placed on the right.

Screenshot_20241117_153617

  • Describe what your code exactly does and if it affects any other part of the code in any way (especially check for breaking changes)

Swaps the order of the nodes within the ZoomAdjustment component and adjusts the corresponding CSS classes so borders render properly.

Fixes #723

reorders the buttons for the zoom adjustment such that decreasing
zoom is placed on the left and increasing zoom is placed on the
right
@leherkom leherkom force-pushed the fix/zoom-btns-order branch from ad1cfec to 2799eb2 Compare November 17, 2024 15:14
@trobonox
Copy link
Member

LGTM, thanks for helping out with the fix!

@trobonox trobonox merged commit 19e8437 into kanriapp:main Nov 17, 2024
1 check passed
@leherkom leherkom deleted the fix/zoom-btns-order branch November 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom buttons swapped
2 participants