Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: version without vbox #13

Open
egandro opened this issue May 24, 2024 · 4 comments · May be fixed by #14
Open

feature request: version without vbox #13

egandro opened this issue May 24, 2024 · 4 comments · May be fixed by #14
Labels
enhancement New feature or request

Comments

@egandro
Copy link

egandro commented May 24, 2024

I have a (maybe silly) feature request.

Can you offer a version without vbox bundled?

Thank you.
@kaosagnt
Copy link
Owner

You don't have to install virtual box. Do a custom install by deselecting virtual box. Why do you need a virtual box removed?

@egandro
Copy link
Author

egandro commented May 27, 2024

You don't have to install virtual box. Do a custom install by deselecting virtual box. Why do you need a virtual box removed?

It's more about the download size.

Having a version without the VBox installer

toolbox2docker/Dockerfile.windows

Line 100 in 44e9ff5

RUN wine virtualbox.exe -extract -silent -path . && \

is simple to create - we just need a 2nd Dockerfile or parameterize the Dockerfile.

Would you accept a PR?

@kaosagnt
Copy link
Owner

Sure, Let's see what you come up with.

@kaosagnt kaosagnt added the enhancement New feature or request label May 27, 2024
@egandro
Copy link
Author

egandro commented May 29, 2024

Have a look at my PR.

@kaosagnt kaosagnt linked a pull request Jun 5, 2024 that will close this issue
lite version without vbox #14
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lite version without vbox egandro/toolbox2docker
2 participants
@egandro @kaosagnt