Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validate to support globbed paths and autodetect kinds #908

Open
ademariag opened this issue Dec 7, 2022 · 1 comment
Open

Improve validate to support globbed paths and autodetect kinds #908

ademariag opened this issue Dec 7, 2022 · 1 comment
Assignees
Labels
enhancement enhancement to an existing feature Stale

Comments

@ademariag
Copy link
Contributor

Describe the feature
the output_paths for validate does not support globbed path, and requires indicating the kind to validate.

My propose change adds support for

  • detecting globbed paths
  • auto-detecting kind from loaded documents

To Reproduce
Steps to reproduce the behavior:

    validate:
    - type: kubernetes
      output_paths:
        - manifests/*-secret.yml
      kind: secret
      version: 1.14.0

Expected behavior

apitan compile --validate -t dev
Rendered inventory (0.08s)
Compiled dev (0.12s)


invalid 'Ingress' manifest at ./compiled/dev/manifests/global-ingress.yml
['spec', 'rules', 0, 'http', 'paths', 0] Additional properties are not allowed ('pathType' was unexpected)
['spec', 'rules', 0, 'http', 'paths', 0, 'backend'] Additional properties are not allowed ('service' was unexpected)
['spec', 'rules', 0, 'http', 'paths', 0, 'backend'] 'serviceName' is a required property
['spec', 'rules', 0, 'http', 'paths', 0, 'backend'] 'servicePort' is a required property
@ademariag ademariag self-assigned this Dec 7, 2022
@ademariag ademariag linked a pull request Dec 8, 2022 that will close this issue
@MatteoVoges MatteoVoges added the enhancement enhancement to an existing feature label Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to an existing feature Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants