Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockFile is global for all users #162

Open
izahn opened this issue Apr 13, 2021 · 1 comment · May be fixed by #173
Open

lockFile is global for all users #162

izahn opened this issue Apr 13, 2021 · 1 comment · May be fixed by #173

Comments

@izahn
Copy link

izahn commented Apr 13, 2021

I found that if more than one user in a multi-user linux environment tries to use rclone-browser at the same time we get message saying that "Rclone Browser is already running. Only one instance is allowed.".

It looks like

QLockFile lockFile(tmpDir + "/.RcloneBrowser_4q6RgLs2RpbJA.lock");
implements a global lock instead of a per-user lock. Is that intended? I've patched this up locally with

  char* lockLocalUserName = std::getenv("USER");
  QLockFile lockFile(tmpDir + "/." + lockLocalUserName + "RcloneBrowser_4q6RgLs2RpbJA.lock");

but I don't know if this is the right approach, or if the global lock was intentional.

@kapitainsky
Copy link
Owner

kapitainsky commented Apr 13, 2021 via email

@izahn izahn linked a pull request Jul 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants