perf: make events somewhat faster #610
Open
+66
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isn't working [skip actions]
eatlove still kinda works, but player does not appear for some reason
…th the tag Co-authored-by: Marc Flerackers <[email protected]>
mflerackers
approved these changes
Feb 17, 2025
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this should make the evnt system a little faster, the tag-based events in particular.
Previously tag-baed events fired on all objects, but just returned early if the object wasn't the right tag; now, using the onTag and onUntag events the handlers are dynamically added and removed when tags change, reducing the overhead on each handler.
The big 3 per-frame events (onUpdate, onfixedUpdate, and onDraw) and also now handled using inlined
KEvents so that the routing overhead and extra function calls of looking up the named event handler inKEventHandlergoes away.