Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcli delete plan doesn't delete dns entries defined in a plan #695

Open
palonsoro opened this issue Jul 4, 2024 · 5 comments
Open

kcli delete plan doesn't delete dns entries defined in a plan #695

palonsoro opened this issue Jul 4, 2024 · 5 comments

Comments

@palonsoro
Copy link
Contributor

If I define dns entries in a plan, those get created as expected but when the plan is deleted with kcli delete plan, those are never deleted, leaving stale DNS entries.

@palonsoro
Copy link
Contributor Author

Possible way to go: Record in network metadata which hostname-ip DNS associations are managed by kcli under each plan and look for those while deleting. Not perfect, but at least better than nothing.

@karmab
Copy link
Owner

karmab commented Jul 4, 2024

while it can certainly be improved, not that when recreating those dns entries, they get updated with the correct ips if necessary

@palonsoro
Copy link
Contributor Author

Even if created under a different plan? Regardless of whether what changes is the ip or the host part?

@karmab
Copy link
Owner

karmab commented Jul 6, 2024

yes!

@palonsoro
Copy link
Contributor Author

Ok. I have had problems in the past with the leaked DNS entry, but I cannot tell if it was with a kcli command or a script of my own.

But anyway, even if not high prio, it should be good to avoid the leaks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants