You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The edge cases of deposit and deposit_with_messge call a common internal function accept_deposit which can be directly tested instead of making edge cases for both of them.
Similarly deposit_reclaim and deposit_with_message_reclaim where testcaes have same edge cases with both the functions. We can create a functions that has the cancels the message, think of way to not replicate the testcases
deposit_cancel_request and deposit_with_message_cancel_request can also be improved by calling the start_cancellation in a common function from both of them
Remove the integration test and instead use mock_state_for_testing() function to test the internal function
This will improve the overall readability and maintainability of the testcases
The text was updated successfully, but these errors were encountered:
The edge cases of
deposit
anddeposit_with_messge
call a common internal functionaccept_deposit
which can be directly tested instead of making edge cases for both of them.Similarly
deposit_reclaim
anddeposit_with_message_reclaim
where testcaes have same edge cases with both the functions. We can create a functions that has the cancels the message, think of way to not replicate the testcasesdeposit_cancel_request
anddeposit_with_message_cancel_request
can also be improved by calling thestart_cancellation
in a common function from both of themmock_state_for_testing()
function to test the internal functionThe text was updated successfully, but these errors were encountered: