Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testcase for deposit and deposit with message #8

Open
byteZorvin opened this issue Aug 9, 2024 · 0 comments
Open

improve testcase for deposit and deposit with message #8

byteZorvin opened this issue Aug 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@byteZorvin
Copy link
Member

byteZorvin commented Aug 9, 2024

  1. The edge cases of deposit and deposit_with_messge call a common internal function accept_deposit which can be directly tested instead of making edge cases for both of them.

  2. Similarly deposit_reclaim and deposit_with_message_reclaim where testcaes have same edge cases with both the functions. We can create a functions that has the cancels the message, think of way to not replicate the testcases

  3. deposit_cancel_request and deposit_with_message_cancel_request can also be improved by calling the start_cancellation in a common function from both of them

  • Remove the integration test and instead use mock_state_for_testing() function to test the internal function
  • This will improve the overall readability and maintainability of the testcases
This was referenced Aug 13, 2024
@byteZorvin byteZorvin added the enhancement New feature or request label Aug 19, 2024
@byteZorvin byteZorvin reopened this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant