Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug detected for high-dimension real NVP #5

Open
kfzyqin opened this issue Apr 8, 2020 · 1 comment
Open

Potential bug detected for high-dimension real NVP #5

kfzyqin opened this issue Apr 8, 2020 · 1 comment

Comments

@kfzyqin
Copy link

kfzyqin commented Apr 8, 2020

I found the backflow of real NVP cannot reconstruct the original input data. This is caused by a bug in code when the dimension is more than 2:

x0, x1 = x[:,::2], x[:,1::2]

z0, z1 = z[:,::2], z[:,1::2]

They should be:

x0, x1 = x[:, :self.half_dim], x[:, self.half_dim:]
z0, z1 = z[:, :self.half_dim], z[:, self.half_dim:]

@janosh
Copy link

janosh commented Apr 8, 2020

See #1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants