Skip to content

Latest commit

 

History

History
43 lines (31 loc) · 1.81 KB

pull_request_template.md

File metadata and controls

43 lines (31 loc) · 1.81 KB

Summary

Changes

Types of Pull Request

  • ship (No reviews required, CI makes it safe)
  • show (Feedback wanted, but no review is required for merging)
  • ask (Feedback and in depth code review needed)

Types of changes

  • fix (non-breaking change which fixes an issue)
  • feat (non-breaking change which adds functionality)
  • ci (change affecting the continuous integration process)
  • docs (change in documentation)
  • perf (change that aims to improve or measure performance)
  • refactor (code change that neither is a fix, nor a feature)
  • revert (reverts a previous change)
  • test (change in test files)
  • chore (fallback type - any other change)

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • No hardcoded messages, values, magic numbers
  • New and existing unit tests pass locally with my changes
  • Added and adapted End-to-End tests for my changes
  • Tested on stage; different viewports and devices considered;
  • Accessibility considered and tested