Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orgTag and orgtag currently fail as it is case sensitive #216

Open
timmwille opened this issue Jul 10, 2024 · 3 comments
Open

orgTag and orgtag currently fail as it is case sensitive #216

timmwille opened this issue Jul 10, 2024 · 3 comments
Assignees
Labels
01 enhancement New feature or request

Comments

@timmwille
Copy link

Problem

A clear and concise description of the bug.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a link with &tag=xyz&orgtag=xyz
  2. check for accepted locations only
  3. realise it is all the same as without orgtag
  4. Look for a mistake.

Expected behavior

Outcome of orgTag and orgtag is easily mistaken if one does currently not apply the correct spelling. orgTag and orgtag could be the same result.

Solution

Additional context
I think it is easy to solve via case insensitivity for the writing of orgTag
It took me a long time to figure this out, but can easily happen.

@timmwille timmwille added the 0 bug Something isn't working label Jul 10, 2024
@wellemut wellemut moved this from New Issues to Product Backlog in Improvements after Refactoring Jul 10, 2024
@wellemut
Copy link
Member

wellemut commented Jul 10, 2024

Thanks for this report. Good point but low prio in my eyes
The orgTag feature is no enduser feature, so target group only 20 admins that have technical knowledge, bug tolerance and in 90% of them they get a close help and guidance by experienced mappers...

@timmwille
Copy link
Author

timmwille commented Jul 25, 2024

it actually is a bit confusing to have "orgTag" and "org_tag" in API and URL options plus naturally one tends to write "orgtag" as multiple issue titles proof. - If it is not too much of a pain it would really help to synch this or make agnostic.

It almost stopped us from implementing the map in the way we planned it.

edit: actually there is also OrgTag :D

https://github.com/search?q=repo%3Akartevonmorgen%2Fkartevonmorgen.ts%20orgtag&type=code

@wellemut
Copy link
Member

@flosse
wie kann man die API-Commans nicht mehr case sensitiv machen? Das führt wohl zu langen fehlersuchen.
bzw. wie können wir hier aliasse definieren?

Der Variablen-Namen sollste nicht case sensitiv sein
der Wert darf aber case sensitiv sein.

@wellemut wellemut moved this to Backlog in OpenEcoLab Aug 4, 2024
@wellemut wellemut added 01 enhancement New feature or request and removed 0 bug Something isn't working labels Sep 16, 2024
@wellemut wellemut changed the title [BUG] orgTag and orgtag currently fail as it is case sensitive orgTag and orgtag currently fail as it is case sensitive Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 enhancement New feature or request
Projects
Status: Product Backlog
Status: Backlog
Development

No branches or pull requests

2 participants