Consider usefulness of JSON configuration

[pbrisbin]

I almost always want to modify the sourceFolders option. I never want to add ignores; in fact, I'd argue ignoring tests is an anti-pattern.

Therefore, I propose removing the JSON-based configuration and instead support usage like:

{-# OPTIONS_GHC -F -pgmF doctest-discover -optF app -optF library #-}

As the (only) means of configuration, to override the default of -optF src.

If you agree, I'm happy to open a PR implementing this.

[karun012]

I like the idea, but I'm thinking it's best to keep things backwards compatible or have a different version with no JSON support. Ignoring tests is definitely an anti-pattern. However, it is nice to have that as a feature :-)

…

On Fri, Dec 22, 2017 at 12:34 PM, patrick brisbin ***@***.***> wrote: I almost always want to modify the sourceFolders option. I never want to add ignores; in fact, I'd argue ignoring tests is an anti-pattern. Therefore, I propose removing the JSON-based configuration and instead support usage like: {-# OPTIONS_GHC -F -pgmF doctest-discover -optF app -optF library #-} As the (only) means of configuration, to override the default of -optF src . If you agree, I'm happy to open a PR implementing this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEf7xkHih4llnm11Wo_63dlLZZ1SBHuks5tDBI6gaJpZM4RLZ2k> .

[pbrisbin]

We could keep backwards compatibility, and the ignore feature, by supporting two usages:

doctest-discover [CONFIG]
doctest-discover [--ignore PATTERN, ...] [DIRECTORY, ...]

It would require a more complex options-parser, but not much other downside I see.

My main motivation is that I don't like cruft in my source tree, so I'd prefer I can fully configure the doctest target within the single Haskell module, rather than also requriing a sidecar JSON file.

[karun012]

Good idea.

…

On Tue, Dec 26, 2017 at 9:02 AM, patrick brisbin ***@***.***> wrote: We could keep backwards compatibility, and the ignore feature, by supporting two usages: doctest-discover [CONFIG] doctest-discover [--ignore PATTERN, ...] [DIRECTORY, ...] It would require a more complex options-parser, but not much other downside I see. My main motivation is that I don't like cruft in my source tree, so I'd prefer I can fully configure the doctest target within the single Haskell module, rather than also requriing a sidecar JSON file. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEf73UCwl3Yb3ENtagBkmDqAY-2iPzHks5tESaugaJpZM4RLZ2k> .