Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a problem with Chinese character calculation #11

Open
z3season opened this issue Nov 17, 2020 · 2 comments
Open

There is a problem with Chinese character calculation #11

z3season opened this issue Nov 17, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@z3season
Copy link

There is a problem with Chinese character calculation

image

@kashishgrover
Copy link
Owner

Hi @seasonZzl. Thanks for raising this issue. I'll get to this in time, but I have a feeling that this has something to do with adjustment in the calculation logic. Try going through getTruncationIndex(...) function in SeeMoreUtil.js file and see what is happening there. Embarrassingly enough, I wrote these functions with only English in mind and I didn't test it for other languages at all.

Please raise a PR if you find a generic fix, else I will check this over the weekend.

Cheers!

@z3season
Copy link
Author

Hi @seasonZzl. Thanks for raising this issue. I'll get to this in time, but I have a feeling that this has something to do with adjustment in the calculation logic. Try going through getTruncationIndex(...) function in SeeMoreUtil.js file and see what is happening there. Embarrassingly enough, I wrote these functions with only English in mind and I didn't test it for other languages at all.

Please raise a PR if you find a generic fix, else I will check this over the weekend.

Cheers!

I looked at this method getTruncationIndex(...), Chinese characters are different in width and height from English characters, now consider wrapping native controls to implementation

@kashishgrover kashishgrover added the good first issue Good for newcomers label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants