From 9fa69fc896bf6fced2ce56d7d170572f60c8d89e Mon Sep 17 00:00:00 2001 From: Therapon Skoteiniotis Date: Fri, 14 Jul 2023 23:42:15 -0700 Subject: [PATCH] engine beta release fixes (#516) * create [beta release on GitHub](https://github.com/kaskada-ai/kaskada/releases/tag/engine%40v0.9.0-beta.1) * pushed docker images for engine and jupyter for both GitHub and DockerHub * https://github.com/kaskada-ai/kaskada/pkgs/container/kaskada%2Fengine * https://github.com/kaskada-ai/kaskada/pkgs/container/kaskada%2Fjupyter * https://hub.docker.com/layers/kaskadaio/engine/v0.9.0-beta.1/images/sha256-b5496497e718f557eade6a15e24435005cc56066a22146c8767179b2719809c6?context=explore * https://hub.docker.com/layers/kaskadaio/jupyter/v0.9.0-beta.1/images/sha256-8ccca38221d1b0e3a6dadac7ec785c7a5db0f0aa82a00c7b0bf29d71a776a43f?context=explore Will follow up with a small PR on documentation. --- .github/workflows/release_engine.yml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release_engine.yml b/.github/workflows/release_engine.yml index 5efdf6d6e..7a0c7f0bf 100644 --- a/.github/workflows/release_engine.yml +++ b/.github/workflows/release_engine.yml @@ -72,11 +72,16 @@ jobs: echo Release Tag: ${{ steps.draft_release.outputs.tag_name }} echo Release HTML URL: ${{ steps.draft_release.outputs.html_url }} - - name: Diagnostics for Beta + # For beta releases we need to create the beta release first so that + # jobs and steps that follow can upload artifacts. + - name: Create Release for Beta if: startsWith(github.ref, 'refs/tags/engine@v') && contains(github.ref, 'beta') run: | echo Release Input Version: ${{ steps.determine_version.outputs.version }} - + gh release create ${TAG} --repo ${GITHUB_REPOSITORY} -p -t "Engine BETA : ${TAG}" + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + TAG: ${{ github.ref_name }} release_engine_cross_build: name: Cross build release for aarch64 linux @@ -228,16 +233,15 @@ jobs: # Currently we create a Beta release without any notes or changelog in the GitHub release page. # Need to figure out how to use the drafter without taking over the draft release. - - name: Create Beta release and add artifacts + - name: Add artifacts to Beta release if: startsWith(github.ref, 'refs/tags/engine@v') && contains(github.ref, 'beta') run: | - gh release create ${TAG} -p -t "Engine BETA : ${TAG}" cp release/sparrow-main${{ matrix.exe }} ${ENGINE_ASSET_NAME} - gh release upload ${TAG} ${ENGINE_ASSET_NAME} --clobber + gh release upload ${TAG} --repo ${GITHUB_REPOSITORY} ${ENGINE_ASSET_NAME} --clobber cp release/wren${{ matrix.exe }} ${WREN_ASSET_NAME} - gh release upload ${TAG} ${WREN_ASSET_NAME} --clobber + gh release upload ${TAG} --repo ${GITHUB_REPOSITORY} ${WREN_ASSET_NAME} --clobber cp release/cli${{ matrix.exe }} ${CLI_ASSET_NAME} - gh release upload ${TAG} ${CLI_ASSET_NAME} --clobber + gh release upload ${TAG} --repo ${GITHUB_REPOSITORY} ${CLI_ASSET_NAME} --clobber shell: bash env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -254,7 +258,6 @@ jobs: release_docker_images: name: Build and push Docker images for releases runs-on: ubuntu-latest - if: startsWith(github.ref, 'refs/tags/engine@v') && !contains(github.ref, 'beta') needs: [ "release_engine_draft",