Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bugs in the datasets #82

Closed
6 of 7 tasks
kategerasimenko opened this issue Feb 19, 2023 · 5 comments
Closed
6 of 7 tasks

Potential bugs in the datasets #82

kategerasimenko opened this issue Feb 19, 2023 · 5 comments
Assignees
Labels
bug Something isn't working data Related to datasets in progress Some work has already been done

Comments

@kategerasimenko
Copy link
Collaborator

kategerasimenko commented Feb 19, 2023

This is the list of the things that I found weird and will need double-checking.

  • scigen - text and reference confused?
  • scigen - for values in bold, _h object in cell value, error when linearizing
  • numericnlg - refs don't look like refs
  • logic2text - look into the highlights provided by contlog
  • logicnlg - restore the highlights, add disclaimer
  • hitab train 66 - error
  • sportsett - why first three cols empty? upd: fixed by fix cell init #78
@kasnerz
Copy link
Owner

kasnerz commented Feb 20, 2023

Also some datasets are currently showing empty tables (at least on quest), putting a note here to myself to investigate it.

@kasnerz kasnerz added bug Something isn't working data Related to datasets labels Feb 20, 2023
@kategerasimenko
Copy link
Collaborator Author

@kasnerz empty cells are fixed by #78 :)

@kategerasimenko
Copy link
Collaborator Author

@kasnerz numericnlg is not fully uploaded to HF hub - reference field is missing. Should we omit this df for now?

@kasnerz
Copy link
Owner

kasnerz commented Feb 20, 2023

@kategerasimenko You're right! For NumericNLG I included just table captions but there were also files containing related descriptions and a few extra fields. I fixed it on HF and in a15652f

@kategerasimenko kategerasimenko self-assigned this Mar 2, 2023
@kategerasimenko kategerasimenko added the in progress Some work has already been done label Mar 2, 2023
@kategerasimenko
Copy link
Collaborator Author

logic2text is separate issue #112 now, everything else is fixed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data Related to datasets in progress Some work has already been done
Projects
None yet
Development

No branches or pull requests

2 participants