Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit option in RPC getVirtualChainFromBlock #562

Closed
ZenVoich opened this issue Sep 19, 2024 · 3 comments
Closed

Limit option in RPC getVirtualChainFromBlock #562

ZenVoich opened this issue Sep 19, 2024 · 3 comments

Comments

@ZenVoich
Copy link

Is your feature request related to a problem? Please describe.
I want to use getVirtualChainFromBlock to keep only accepted transactions. But there is no limit setting so it always returns all blocks and txs up to the tip. A lot of txs if we start from the pruning point and I suppose a huge amount if I try to call it on historical blocks on archival node.

Describe the solution you'd like
Add limit option so I can iterate using a suitable batch size.

Describe alternatives you've considered
I did not find any other way to check if tx is accepted.

@D-Stacks
Copy link
Collaborator

D-Stacks commented Sep 19, 2024

how important is the ability for you to supply a limit yourself? will sensible defaults implemented by the node be enough?

trying to know if merging #454 will resolve this, or if this is an independent feature request.

@michaelsutton
Copy link
Contributor

#454 was merged and pre-released, which should solve this issue.

@coderofstuff
Copy link
Collaborator

Closed by #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants